Skip to content

Report const eval error inside the query#53821

Merged
bors merged 21 commits intorust-lang:masterfrom
oli-obk:sanity_query
Oct 26, 2018
Merged

Report const eval error inside the query#53821
bors merged 21 commits intorust-lang:masterfrom
oli-obk:sanity_query

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Aug 30, 2018

Functional changes: We no longer warn about bad constants embedded in unused types. This relied on being able to report just a warning, not a hard error on that case, which we cannot do any more now that error reporting is consistently centralized.

r? @RalfJung

fixes #53561

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constant validation is not cached